tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: fix panic when prepare and execute the insert on duplicate (#37924)

Open ti-srebot opened this issue 3 years ago • 4 comments

cherry-pick #37924 to release-6.3 You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/38105

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/38105:release-6.3-d5b2c9b17d44

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/37187

Problem Summary: The prepare and execute statements both will build the plan. But some code path in planBuilder have some assumptions about they only execute once.

What is changed and how it works?

  1. Record the actualColLen in last.InsertStmt for reusing.
  2. Initlizate the actualColLen to 0 not 1. Because it's safe and easy to handle.

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-srebot avatar Sep 22 '22 10:09 ti-srebot

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 22 '22 10:09 ti-chi-bot

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 22 '22 10:09 ti-chi-bot

/run-all-tests

ti-srebot avatar Sep 22 '22 10:09 ti-srebot

@Reminiscent you're already a collaborator in bot's repo.

ti-srebot avatar Sep 22 '22 10:09 ti-srebot

@ti-srebot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 9df1a6376d87082bc40308d0802a559113242ef9 link true /test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot avatar Dec 29 '22 05:12 ti-chi-bot