pingcap
store/copr: update copr-cache admission for paging and initial copr task's paging size (#38012)
cherry-pick #38012 to release-6.3 You can switch your code base to this Pull Request by using git-extras:
# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/38077
After apply modifications, you can push your change to this PR via:
git push [email protected]:ti-srebot/tidb.git pr/38077:release-6.3-16693f8cd2f6
What problem does this PR solve?
Issue Number: close #37768 #37974
Problem Summary:
What is changed and how it works?
I figure out that for Q17, the root cause of the issue is copr-cache https://github.com/pingcap/tidb/issues/37768#issuecomment-1252098134
When paging is disabled, the copr cache admission check would check the copr request data size < 10M When paging is enable, this check become useless because the data is much smaller.
I add a pagingTaskIdx and check if pagingTaskIdx is large, don't cache the data.
Check List
Tests
- [ ] Unit test
- [X] Integration test
I'll run the TPCH bench bot to verify the change work.
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- XuHuaiyu
- xhebox
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@ti-srebot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| idc-jenkins-ci-tidb/mysql-test | 28e831543fd009a86195a5e8390d75d81658893f | link | true | /test mysql-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
