tidb
tidb copied to clipboard
pingcap
br/restore: try keep table ID when possible
What problem does this PR solve?
Issue Number: close #(TBD)
Problem Summary: Key Rewriting is a heavy operation and may slow down the restoration. We can try to reduce it when possible.
What is changed and how it works?
This PR make BR try to keep the table ID when restoring.
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
| Field | With reuse table ID | Without reuse table ID |
|---|---|---|
| CPU Usage |  |
 |
| Speed |  |
 |
- [ ] No code
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Speed up restoration of new clusters.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- 3pointer
- Leavrth
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.
Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @Leavrth @joccau PTAL
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This pull request has been accepted and is ready to merge.
TiDB MergeCI notify
🔴 Bad News! New failing [2] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
| CI Name | Result | Duration | Compare with Parent commit |
|---|---|---|---|
| idc-jenkins-ci-tidb/sqllogic-test-2 | 🟥 failed 5, success 23, total 28 | 6 min 23 sec | New failing |
| idc-jenkins-ci-tidb/sqllogic-test-1 | 🟥 failed 8, success 18, total 26 | 3 min 44 sec | New failing |
| idc-jenkins-ci-tidb/integration-common-test | 🔴 failed 3, success 14, total 17 | 14 min | Existing failure |
| idc-jenkins-ci-tidb/tics-test | 🔴 failed 1, success 0, total 1 | 4 min 13 sec | Existing failure |
| idc-jenkins-ci-tidb/integration-ddl-test | 🟢 all 6 tests passed | 29 min | Existing passed |
| idc-jenkins-ci/integration-cdc-test | 🟢 all 37 tests passed | 25 min | Existing passed |
| idc-jenkins-ci-tidb/common-test | 🟢 all 11 tests passed | 9 min 13 sec | Existing passed |
| idc-jenkins-ci-tidb/mybatis-test | 🟢 all 1 tests passed | 6 min 52 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 6 min 13 sec | Existing passed |
| idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |
