tidb icon indicating copy to clipboard operation
tidb copied to clipboard

types: Fix `TIMESTAMPADD` lost fractional digits

Open birdstorm opened this issue 2 years ago • 1 comments

Signed-off-by: birdstorm [email protected]

What problem does this PR solve?

Issue Number: close #31795

Problem Summary:

What is changed and how it works?

TiDB lost fractional digits when using SECOND as unit type for interval. Refrence

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [x] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

birdstorm avatar Sep 20 '22 10:09 birdstorm

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 20 '22 10:09 ti-chi-bot

/run-mysql-test tidb-test=pr/2018

birdstorm avatar Nov 16 '22 08:11 birdstorm

/run-mysql-test tidb-test=pr/2018

birdstorm avatar Nov 17 '22 06:11 birdstorm

/run-check_dev_2

birdstorm avatar Nov 17 '22 07:11 birdstorm

/run-mysql-test tidb-test=pr/2018

birdstorm avatar Nov 17 '22 10:11 birdstorm

/merge

windtalker avatar Nov 21 '22 05:11 windtalker

This pull request has been accepted and is ready to merge.

Commit hash: 330599d7b9d34342ec04ff62c75b9f1a17f8538c

ti-chi-bot avatar Nov 21 '22 05:11 ti-chi-bot

/run-mysql-test tidb-test=pr/2018

windtalker avatar Nov 21 '22 05:11 windtalker

/run-unit-test

birdstorm avatar Nov 21 '22 06:11 birdstorm

/run-unit-test

birdstorm avatar Nov 21 '22 08:11 birdstorm

In response to a cherrypick label: new pull request created: #39285.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39286.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39287.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39288.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39289.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39290.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

In response to a cherrypick label: new pull request created: #39291.

ti-chi-bot avatar Nov 21 '22 08:11 ti-chi-bot

TiDB MergeCI notify

🔴 Bad News! New failing [3] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 16 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 9 min 21 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 21 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 38, total 39 21 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 40 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Nov 21 '22 09:11 sre-bot

In response to MergeCI:

  • common-test and integration-common-test are related to mysql-test pr#2018, and should be fixed now after merging.
  • other test failures are not related to this PR

birdstorm avatar Nov 21 '22 09:11 birdstorm