tidb
tidb copied to clipboard
types: Fix `TIMESTAMPADD` lost fractional digits
Signed-off-by: birdstorm [email protected]
What problem does this PR solve?
Issue Number: close #31795
Problem Summary:
What is changed and how it works?
TiDB lost fractional digits when using SECOND
as unit type for interval. Refrence
Check List
Tests
- [x] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [x] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- windtalker
- winoros
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
/run-mysql-test tidb-test=pr/2018
/run-mysql-test tidb-test=pr/2018
/run-check_dev_2
/run-mysql-test tidb-test=pr/2018
/merge
This pull request has been accepted and is ready to merge.
/run-mysql-test tidb-test=pr/2018
/run-unit-test
/run-unit-test
In response to a cherrypick label: new pull request created: #39285.
In response to a cherrypick label: new pull request created: #39286.
In response to a cherrypick label: new pull request created: #39287.
In response to a cherrypick label: new pull request created: #39288.
In response to a cherrypick label: new pull request created: #39289.
In response to a cherrypick label: new pull request created: #39290.
In response to a cherrypick label: new pull request created: #39291.
TiDB MergeCI notify
🔴 Bad News! New failing [3] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
CI Name | Result | Duration | Compare with Parent commit |
---|---|---|---|
idc-jenkins-ci-tidb/integration-common-test | 🟥 failed 2, success 15, total 17 | 16 min | New failing |
idc-jenkins-ci-tidb/common-test | 🟥 failed 1, success 10, total 11 | 9 min 21 sec | New failing |
idc-jenkins-ci-tidb/integration-ddl-test | 🟥 failed 1, success 5, total 6 | 6 min 21 sec | New failing |
idc-jenkins-ci/integration-cdc-test | 🔴 failed 1, success 38, total 39 | 21 min | Existing failure |
idc-jenkins-ci-tidb/mybatis-test | 🔴 failed 1, success 0, total 1 | 11 min | Existing failure |
idc-jenkins-ci-tidb/tics-test | 🟢 all 1 tests passed | 6 min 40 sec | Existing passed |
idc-jenkins-ci-tidb/sqllogic-test-2 | 🟢 all 28 tests passed | 4 min 51 sec | Existing passed |
idc-jenkins-ci-tidb/sqllogic-test-1 | 🟢 all 26 tests passed | 4 min 42 sec | Existing passed |
idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 2 min 43 sec | Existing passed |
idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |
In response to MergeCI:
-
common-test
andintegration-common-test
are related tomysql-test pr#2018
, and should be fixed now after merging. - other test failures are not related to this PR