tidb icon indicating copy to clipboard operation
tidb copied to clipboard

preprocessor, planner: inline processing by default for single-consumer cte

Open elsa0520 opened this issue 2 years ago • 6 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

elsa0520 avatar Sep 14 '22 04:09 elsa0520

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fixdb
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 14 '22 04:09 ti-chi-bot

The pushed diff missed that push the new slice into the stack when we meet a new query block?

Some code forgot to submit 😭

elsa0520 avatar Sep 15 '22 11:09 elsa0520

How to rerun check_dev_2 ?L Looking at the error log, it seems to be a problem with the master itself, not this pr.

elsa0520 avatar Sep 19 '22 11:09 elsa0520

/run-check_dev_2

time-and-fate avatar Sep 19 '22 11:09 time-and-fate

/run-check_dev_2

Thanks ~

elsa0520 avatar Sep 19 '22 11:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 26 '22 02:09 elsa0520

/run-unit-test

elsa0520 avatar Sep 26 '22 03:09 elsa0520

@elsa0520 issue https://github.com/pingcap/tidb/issues/36295

fixdb avatar Sep 27 '22 04:09 fixdb

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 05:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 05:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 05:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 05:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 06:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 07:09 elsa0520

/merge

winoros avatar Sep 27 '22 07:09 winoros

This pull request has been accepted and is ready to merge.

Commit hash: 8f0cbaf0454e4a269ffdf3a3bfb0aa6868ec73e6

ti-chi-bot avatar Sep 27 '22 07:09 ti-chi-bot

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 08:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 27 '22 08:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 28 '22 02:09 elsa0520

/run-mysql-test tidb-test=pr/1976

elsa0520 avatar Sep 28 '22 06:09 elsa0520

/run-check-dev

wuhuizuo avatar Sep 28 '22 06:09 wuhuizuo

/run-check-dev

wuhuizuo avatar Sep 28 '22 06:09 wuhuizuo

/run-check-dev

wuhuizuo avatar Sep 28 '22 07:09 wuhuizuo

/run-check-dev

wuhuizuo avatar Sep 28 '22 07:09 wuhuizuo

/run-check-dev

wuhuizuo avatar Sep 28 '22 08:09 wuhuizuo

/merge

chrysan avatar Sep 28 '22 15:09 chrysan

This pull request has been accepted and is ready to merge.

Commit hash: 69ba7fe8e623c803d0b49f7e3cc02c8169168d5a

ti-chi-bot avatar Sep 28 '22 15:09 ti-chi-bot

/merge

fixdb avatar Sep 28 '22 15:09 fixdb

@fixdb: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Sep 28 '22 15:09 ti-chi-bot

/run-mysql-test

fixdb avatar Sep 28 '22 15:09 fixdb