tidb icon indicating copy to clipboard operation
tidb copied to clipboard

TestDAGPlanBuilderUnionScan is a break test

Open hawkingrei opened this issue 3 years ago • 4 comments

Bug Report

Please answer these questions before submitting your issue. Thanks!

https://github.com/pingcap/tidb/blob/6b8cf9d5b29b160ecb20513895fab05bffb6ae3b/planner/core/physical_plan_test.go#L361-L374

TestDAGPlanBuilderUnionScan forget to load the test data. so it always passes to test.

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

hawkingrei avatar Sep 05 '22 08:09 hawkingrei

In the nogo_config.json, we have an config about this problem.

"planner/core/physical_plan_test.go": "please fix it",

after you fix it, Please remove it.

hawkingrei avatar Sep 05 '22 08:09 hawkingrei

/assign @fzzf678

chrysan avatar Sep 08 '22 02:09 chrysan

@chrysan: GitHub didn't allow me to assign the following users: fzzf678.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @fzzf678

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 08 '22 02:09 ti-chi-bot

/assign

fzzf678 avatar Sep 22 '22 07:09 fzzf678