tidb icon indicating copy to clipboard operation
tidb copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

*: add foreign key constraint check when execute insert statement

Open crazycs520 opened this issue 3 years ago • 4 comments

What problem does this PR solve?

Issue Number: close #37465

What is changed and how it works?

Add foreign key constraint check when insert/update/delete into foreign key child/parent table.

More design detail see the design doc: https://github.com/pingcap/tidb/pull/35982

Related Integration Test: https://github.com/pingcap/tidb-test/pull/1965

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

crazycs520 avatar Aug 30 '22 07:08 crazycs520

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 30 '22 07:08 ti-chi-bot

/run-mysql-test tidb-test=pr/1965

crazycs520 avatar Sep 15 '22 05:09 crazycs520

Rest LGTM

AilinKid avatar Sep 21 '22 03:09 AilinKid

@morgo pls take another look again

AilinKid avatar Sep 21 '22 08:09 AilinKid

/merge

morgo avatar Sep 23 '22 16:09 morgo

This pull request has been accepted and is ready to merge.

Commit hash: 542cbc90e30b8bf6a45b45f4b4126c5cc3667d08

ti-chi-bot avatar Sep 23 '22 16:09 ti-chi-bot

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 36, total 37 29 min New failing
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 11 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 48 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 28 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 47 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 59 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Sep 23 '22 17:09 sre-bot