tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: move logic of plan cache stmt checking to plan cache backend

Open qw4990 opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: move logic of plan cache stmt checking to plan cache backend

What is changed and how it works?

No logical change, just move logic of plan cache stmt checking to plan cache backend

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

qw4990 avatar Aug 11 '22 09:08 qw4990

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 11 '22 09:08 ti-chi-bot

/run-check_dev_2

hawkingrei avatar Aug 11 '22 09:08 hawkingrei

/merge

qw4990 avatar Aug 11 '22 10:08 qw4990

This pull request has been accepted and is ready to merge.

Commit hash: 4d46763dab241f7d4262c6cda379f78ff737532e

ti-chi-bot avatar Aug 11 '22 10:08 ti-chi-bot

/merge

qw4990 avatar Aug 11 '22 10:08 qw4990

/hold

@qw4990 Please fix the test.

hawkingrei avatar Aug 11 '22 14:08 hawkingrei

/run-all-tests

hawkingrei avatar Aug 13 '22 04:08 hawkingrei

/unhold

hawkingrei avatar Aug 13 '22 06:08 hawkingrei

/merge

qw4990 avatar Aug 15 '22 02:08 qw4990

/merge

qw4990 avatar Aug 15 '22 03:08 qw4990

/merge

qw4990 avatar Aug 15 '22 06:08 qw4990

This pull request has been accepted and is ready to merge.

Commit hash: 0850b9afcf3582a6f292eb23ae2f843040d7b78d

ti-chi-bot avatar Aug 15 '22 06:08 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a2142224e69d023cb06a20ae665d15b6ec3adea9

sre-bot avatar Aug 15 '22 06:08 sre-bot

/merge

qw4990 avatar Aug 15 '22 07:08 qw4990

This pull request has been accepted and is ready to merge.

Commit hash: a2142224e69d023cb06a20ae665d15b6ec3adea9

ti-chi-bot avatar Aug 15 '22 07:08 ti-chi-bot

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 7 min 59 sec New failing
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 15 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 19 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 16 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 15 '22 07:08 sre-bot