tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: support ACCOUNT (UN)LOCK when creating/altering user

Open CbcWestwolf opened this issue 3 years ago • 2 comments

What problem does this PR solve?

Issue Number: close #37051

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [x] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

CbcWestwolf avatar Aug 11 '22 08:08 CbcWestwolf

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 11 '22 09:08 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7333d41acf1bc4c4a9a0cb08d1e124e79f3972e1

sre-bot avatar Aug 11 '22 09:08 sre-bot

/run-all-tests

hawkingrei avatar Aug 15 '22 15:08 hawkingrei

/run-unit-test

hawkingrei avatar Aug 15 '22 15:08 hawkingrei

/run-unit-test

hawkingrei avatar Aug 15 '22 15:08 hawkingrei

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 16 '22 02:08 CbcWestwolf

PTAL @tiancaiamao

bb7133 avatar Aug 16 '22 13:08 bb7133

/hold

CbcWestwolf avatar Aug 16 '22 15:08 CbcWestwolf

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 19 '22 07:08 CbcWestwolf

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 24 '22 09:08 CbcWestwolf

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 24 '22 09:08 CbcWestwolf

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 25 '22 07:08 CbcWestwolf

/merge

tiancaiamao avatar Aug 25 '22 07:08 tiancaiamao

This pull request has been accepted and is ready to merge.

Commit hash: a6115df8bf9d94029673ff3b86fe6408fc10d8d4

ti-chi-bot avatar Aug 25 '22 07:08 ti-chi-bot

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 25 '22 07:08 CbcWestwolf

/unhold

tiancaiamao avatar Aug 25 '22 07:08 tiancaiamao

/run-mysql-test tidb-test=pr/1923

CbcWestwolf avatar Aug 25 '22 08:08 CbcWestwolf

/run-mysql-test tidb-test=pr/1923 /merge

tiancaiamao avatar Aug 25 '22 08:08 tiancaiamao

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 9, total 11 14 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 11 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 59 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 57 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 4 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 25 '22 09:08 sre-bot