tidb icon indicating copy to clipboard operation
tidb copied to clipboard

table/tables: fix bug for jepsen test on cached table

Open tiancaiamao opened this issue 3 years ago • 2 comments

What problem does this PR solve?

Issue Number: close #36885

Problem Summary:

What is changed and how it works?

There are two places err not returned, two places lease value decrease.

Check List

Tests

  • [ ] Unit test
  • [X] Integration test

Integration jepsen test

  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiancaiamao avatar Aug 10 '22 08:08 tiancaiamao

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 10 '22 08:08 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b120df15b30110d4c724510849838cffc21b11c9

sre-bot avatar Aug 10 '22 08:08 sre-bot

/merge

hawkingrei avatar Aug 16 '22 08:08 hawkingrei

This pull request has been accepted and is ready to merge.

Commit hash: 5d84575c13b23a39d170b4742306bd11acf5fe3b

ti-chi-bot avatar Aug 16 '22 08:08 ti-chi-bot

cherry pick to release-6.0 in PR #37146

ti-srebot avatar Aug 16 '22 09:08 ti-srebot

cherry pick to release-6.1 in PR #37149

ti-srebot avatar Aug 16 '22 09:08 ti-srebot

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged. These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 5 min 14 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 36 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 16 '22 09:08 sre-bot

cherry pick to release-6.2 in PR #37151

ti-srebot avatar Aug 16 '22 09:08 ti-srebot