tidb icon indicating copy to clipboard operation
tidb copied to clipboard

Planner: automatically inline CTE when only 1 consumer use it

Open dayicklp opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number: close #36295

Problem Summary: We should automatically expand the CTE inline when the CTE query is only used once by the consumer

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

dayicklp avatar Aug 09 '22 09:08 dayicklp

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 09 '22 09:08 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b6e95a30d806392bca7e1217d35a4b85013c2f6d

sre-bot avatar Aug 09 '22 09:08 sre-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jun 05 '23 07:06 ti-chi-bot[bot]

Codecov Report

Merging #36992 (b6e95a3) into master (fbbae46) will increase coverage by 11.9544%. Report is 5512 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #36992         +/-   ##
=================================================
+ Coverage   61.8719%   73.8263%   +11.9544%     
=================================================
  Files           891        990         +99     
  Lines        284074     313709      +29635     
=================================================
+ Hits         175762     231600      +55838     
+ Misses        94536      67522      -27014     
- Partials      13776      14587        +811     

codecov[bot] avatar Oct 13 '23 12:10 codecov[bot]