tidb icon indicating copy to clipboard operation
tidb copied to clipboard

WIP: executor: releasing the memory used by hash join executor when it finished

Open mengxin9014 opened this issue 3 years ago • 4 comments

What problem does this PR solve?

It will release the memory of hash join executor used when hash join executor finished.

Issue Number: close #36989

Problem Summary: Now the memory used by hash join executor will not be released when it finished

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

releasing the memory used by hash join executor when it finished.

mengxin9014 avatar Aug 09 '22 09:08 mengxin9014

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 09 '22 09:08 ti-chi-bot

/run-all-tests

mengxin9014 avatar Aug 09 '22 09:08 mengxin9014

/run-all-tests

mengxin9014 avatar Aug 09 '22 10:08 mengxin9014

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eead6128aee4340a165a1232638612a1027a25c2

sre-bot avatar Aug 09 '22 11:08 sre-bot

/cc @XuHuaiyu @wshwsh12 PTAL

mengxin9014 avatar Aug 30 '22 07:08 mengxin9014

@mengxin9014: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @XuHuaiyu @wshwsh12 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Aug 30 '22 07:08 ti-chi-bot

@mengxin9014: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 25 '22 09:09 ti-chi-bot