tidb icon indicating copy to clipboard operation
tidb copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

lightning: support column starts with slash/number/non-ascii for parquet

Open D3Hunter opened this issue 2 years ago • 4 comments

What problem does this PR solve?

Issue Number: close #36980 close #36981

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support column starts with slash/number/non-ascii for parquet file

D3Hunter avatar Aug 09 '22 06:08 D3Hunter

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 09 '22 06:08 ti-chi-bot

/run-integration-br-test

D3Hunter avatar Aug 09 '22 06:08 D3Hunter

/cc @buchuitoudegou @dsdashun

D3Hunter avatar Aug 09 '22 06:08 D3Hunter

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fac193b816ecfca9684d0d7f591148924613d1fd

sre-bot avatar Aug 09 '22 06:08 sre-bot

/merge

lichunzhu avatar Aug 15 '22 06:08 lichunzhu

This pull request has been accepted and is ready to merge.

Commit hash: 6c47e4ef1ded1c3fe578be6c856e5b5e56fb7040

ti-chi-bot avatar Aug 15 '22 06:08 ti-chi-bot

cherry pick to release-5.4 in PR #37092

ti-srebot avatar Aug 15 '22 06:08 ti-srebot

cherry pick to release-6.1 in PR #37093

ti-srebot avatar Aug 15 '22 06:08 ti-srebot

cherry pick to release-6.2 in PR #37095

ti-srebot avatar Aug 15 '22 07:08 ti-srebot

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 14 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 11 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 15 '22 07:08 sre-bot