tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: add warn log for sync stats

Open Yisaer opened this issue 3 years ago • 2 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

add warn log for sync stats and link it with sql digest.

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer avatar Aug 08 '22 03:08 Yisaer

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 08 '22 03:08 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/477cb187b7b3cafd200b051f1acd5c8ed51500be

sre-bot avatar Aug 08 '22 03:08 sre-bot

Please test the failure path by UT or FT. Rest LGTM.

updated

Yisaer avatar Aug 19 '22 03:08 Yisaer

/merge

Yisaer avatar Aug 22 '22 06:08 Yisaer

This pull request has been accepted and is ready to merge.

Commit hash: 3f44942bea644ce6fa4acc705f497219f27b2771

ti-chi-bot avatar Aug 22 '22 06:08 ti-chi-bot

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 7 min 40 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 33 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 6 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 57 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 22 '22 08:08 sre-bot