tidb
tidb copied to clipboard
pingcap
planner: fix the wrong join reorder produced by some right ouer join (#36936)
cherry-pick #36936 to release-6.1 You can switch your code base to this Pull Request by using git-extras:
# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36938
After apply modifications, you can push your change to this PR via:
git push [email protected]:ti-srebot/tidb.git pr/36938:release-6.1-1e040684e1f3
What problem does this PR solve?
Issue Number: close #36912
Problem Summary: The wrong slice usage lead to wrong join group checking
What is changed and how it works?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- AilinKid
- time-and-fate
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@dayicklp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a59272230ff7abcba504ca2ee9200be5224b2552
This pull request has been accepted and is ready to merge.
@ti-srebot: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
