tidb
tidb copied to clipboard
pingcap
ddl: Fix for unsigned partitioning expressions
What problem does this PR solve?
Issue Number: close #35827
Problem Summary:
What is changed and how it works?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- bb7133
- tiancaiamao
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/942b804e11e122c71f6af82d57e28d87b60646f9
@ymkzpx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.
@mjonss Please fix the code.
[2022-08-18T05:48:13.592Z] Use --sandbox_debug to see verbose messages from the sandbox
[2022-08-18T05:48:13.592Z] ddl/partition.go:1221:24: not enough arguments in call to isPartExprUnsigned
[2022-08-18T05:48:13.592Z] have (*model.TableInfo)
[2022-08-18T05:48:13.592Z] want (sessionctx.Context, *model.TableInfo)
[2022-08-18T05:48:13.592Z] ddl/partition.go:1376:35: not enough arguments in call to isPartExprUnsigned
[2022-08-18T05:48:13.592Z] have (*model.TableInfo)
[2022-08-18T05:48:13.592Z] want (sessionctx.Context, *model.TableInfo)
[2022-08-18T05:48:13.592Z] ddl/partition.go:1439:25: not enough arguments in call to isPartExprUnsigned
[2022-08-18T05:48:13.592Z] have (*model.TableInfo)
[2022-08-18T05:48:13.592Z] want (sessionctx.Context, *model.TableInfo)
[2022-08-18T05:48:13.592Z] ddl/partition.go:2558:6: isPartExprUnsigned redeclared in this block
[2022-08-18T05:48:13.592Z] ddl/partition.go:508:6: other declaration of isPartExprUnsigned
This pull request has been accepted and is ready to merge.
TiDB MergeCI notify
🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
| CI Name | Result | Duration | Compare with Parent commit |
|---|---|---|---|
| idc-jenkins-ci/integration-cdc-test | 🟥 failed 1, success 35, total 36 | 34 min | New failing |
| idc-jenkins-ci-tidb/integration-ddl-test | ✅ all 6 tests passed | 6 min 17 sec | Fixed |
| idc-jenkins-ci-tidb/integration-common-test | 🟢 all 17 tests passed | 20 min | Existing passed |
| idc-jenkins-ci-tidb/common-test | 🟢 all 11 tests passed | 14 min | Existing passed |
| idc-jenkins-ci-tidb/tics-test | 🟢 all 1 tests passed | 7 min 16 sec | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-2 | 🟢 all 28 tests passed | 5 min 37 sec | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-1 | 🟢 all 26 tests passed | 5 min 8 sec | Existing passed |
| idc-jenkins-ci-tidb/mybatis-test | 🟢 all 1 tests passed | 3 min 37 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 3 min 17 sec | Existing passed |
| idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |