tidb
tidb copied to clipboard
pingcap
log-backup: Refactor daemon
What problem does this PR solve?
Issue Number: close #36762
Problem Summary:
See the issue.
What is changed and how it works?
The AdvancerDaemon has been refactored, now, it would be carried by a new type OwnerDaemon, which supports the callback OnBegin.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- 3pointer
- Leavrth
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fa86866c2975fb51b16f0be24d966a0ae2bc1335
This pull request has been accepted and is ready to merge.
TiDB MergeCI notify
🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
| CI Name | Result | Duration | Compare with Parent commit |
|---|---|---|---|
| idc-jenkins-ci-tidb/integration-common-test | 🟥 failed 1, success 16, total 17 | 10 min | New failing |
| idc-jenkins-ci-tidb/integration-ddl-test | ✅ all 6 tests passed | 31 min | Fixed |
| idc-jenkins-ci/integration-cdc-test | ✅ all 37 tests passed | 27 min | Fixed |
| idc-jenkins-ci-tidb/tics-test | 🟢 all 1 tests passed | 20 min | Existing passed |
| idc-jenkins-ci-tidb/common-test | 🟢 all 11 tests passed | 15 min | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-2 | 🟢 all 28 tests passed | 5 min 23 sec | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-1 | 🟢 all 26 tests passed | 4 min 0 sec | Existing passed |
| idc-jenkins-ci-tidb/mybatis-test | 🟢 all 1 tests passed | 3 min 15 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 2 min 44 sec | Existing passed |
| idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |