tidb icon indicating copy to clipboard operation
tidb copied to clipboard

telemetry: interval partitioning

Open mjonss opened this issue 2 years ago • 4 comments

What problem does this PR solve?

Issue Number: close #36525

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added usage of INTERVAL partitioning to telemetry (create, alter first/last partition)

mjonss avatar Jul 22 '22 16:07 mjonss

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jul 22 '22 16:07 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fec2b0384c5fdc56a7f94cce23676e24d5a47cd9

sre-bot avatar Jul 22 '22 16:07 sre-bot

This is based on https://github.com/pingcap/tidb/pull/35662 and should be reviewed as an extension on-top of that PR.

mjonss avatar Jul 25 '22 09:07 mjonss

/run-unit-test

mjonss avatar Aug 09 '22 12:08 mjonss

@ymkzpx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Aug 15 '22 02:08 ti-chi-bot

/merge

tiancaiamao avatar Sep 14 '22 09:09 tiancaiamao

This pull request has been accepted and is ready to merge.

Commit hash: 9fb3ce6e89389602d744a2f0c7b72b2099ff059a

ti-chi-bot avatar Sep 14 '22 09:09 ti-chi-bot

@mjonss: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Sep 14 '22 09:09 ti-chi-bot