tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: add index acceleration introduce sysvars and config param

Open Benjamin2037 opened this issue 3 years ago • 14 comments

What problem does this PR solve?

Add sysvars and config parameter for add index acceleration.

Issue Number: ref #35983

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [X] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code
None

Benjamin2037 avatar Jul 11 '22 08:07 Benjamin2037

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jul 11 '22 08:07 ti-chi-bot

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a169922a06f6794d166bc80f912ab6ee444b41d8

sre-bot avatar Jul 11 '22 08:07 sre-bot

/run-check-dev-2

Benjamin2037 avatar Jul 11 '22 10:07 Benjamin2037

/run-check-dev

Benjamin2037 avatar Jul 11 '22 10:07 Benjamin2037

/run-check-dev

Benjamin2037 avatar Jul 11 '22 10:07 Benjamin2037

/run-check-dev-2

Benjamin2037 avatar Jul 11 '22 10:07 Benjamin2037

/run-check_dev_2

Benjamin2037 avatar Jul 11 '22 11:07 Benjamin2037

/run-check_dev

Benjamin2037 avatar Jul 13 '22 06:07 Benjamin2037

/run-integration-br-test

Benjamin2037 avatar Jul 25 '22 05:07 Benjamin2037

/run-integration-br-test

Benjamin2037 avatar Jul 25 '22 06:07 Benjamin2037

/run-integration-br-test

Benjamin2037 avatar Jul 25 '22 06:07 Benjamin2037

/hold because the config is not decided yet.

tangenta avatar Aug 01 '22 12:08 tangenta

@Benjamin2037: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Aug 03 '22 00:08 ti-chi-bot

/unhold

tangenta avatar Aug 10 '22 06:08 tangenta

/merge

tangenta avatar Aug 12 '22 07:08 tangenta

This pull request has been accepted and is ready to merge.

Commit hash: 3507d092b6881e5f22f0c97bd7e6b817a15ea8a2

ti-chi-bot avatar Aug 12 '22 07:08 ti-chi-bot

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 38 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 28 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 18 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

sre-bot avatar Aug 12 '22 08:08 sre-bot