planner: fix name ambiguous check when building natural join without filter

[AilinKid]

Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #32044

Problem Summary:

What is changed and how it works?

natural join without a filter may find their common columns from both sides first. then, for every common column, we need to make sure that there is exactly one column matches the name for each side.

Check List

Tests

• [x] Unit test
• [ ] Integration test
• [ ] Manual test (add detailed scripts or steps below)
• [ ] No code

Side effects

• [ ] Performance regression: Consumes more CPU
• [ ] Performance regression: Consumes more Memory
• [ ] Breaking backward compatibility

Documentation

• [ ] Affects user behaviors
• [ ] Contains syntax changes
• [ ] Contains variable changes
• [ ] Contains experimental features
• [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix name ambiguous check when building natural join without filter

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f6853c670b2190f4f99342629e9adb7db01056d4

[tiprow[bot]]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov[bot]]

Codecov Report

Merging #36012 (f2a6a04) into master (1760a26) will increase coverage by 2.1483%. Report is 2 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #36012        +/-   ##
================================================
+ Coverage   70.4861%   72.6344%   +2.1483%     
================================================
  Files          1463       1463                
  Lines        433217     433271        +54     
================================================
+ Hits         305358     314704      +9346     
+ Misses       108613      98699      -9914     
- Partials      19246      19868       +622     

Flag	Coverage Δ
integration	48.9156% <100.0000%> (?)
unit	70.2776% <55.5555%> (+0.0018%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.2940% <ø> (ø)
parser	∅ <ø> (∅)
br	51.2310% <ø> (+5.5025%)	:arrow_up:

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [hawkingrei,qw4990]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot[bot]]

[LGTM Timeline notifier]

Timeline:

• 2024-01-26 09:38:51.577154496 +0000 UTC m=+1126373.141452201: :ballot_box_with_check: agreed by hawkingrei.
• 2024-01-28 12:44:23.217689425 +0000 UTC m=+1310304.781987129: :ballot_box_with_check: agreed by qw4990.

[tiprow[bot]]

@AilinKid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	d68fa5fbf2e5adebeb6d46ef85fe268c6a53af42	link	true	/test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tiprow[bot]]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

/cherry-pick release-7.5

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #50904.

[ti-chi-bot]

@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-36012-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-36012-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #51068.