tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: add more test cases for plan cache aware of binding

Open Reminiscent opened this issue 3 years ago • 5 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/29539

Problem Summary: add more test cases for plan cache aware of binding

What is changed and how it works?

  1. session binding and global binding
  2. prepare for ddl statements
  3. capture binding
  4. delete binding
  5. can not create binding because of the using syntax

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

None

Reminiscent avatar Jan 17 '22 06:01 Reminiscent

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jan 17 '22 06:01 ti-chi-bot

/rebuild

zhouqiang-cl avatar Jan 17 '22 06:01 zhouqiang-cl

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5a3be9c2ba54050ffafe5e276864fb3c20072368

sre-bot avatar Jan 18 '22 09:01 sre-bot

@Reminiscent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Mar 16 '22 21:03 ti-chi-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.8198%. Comparing base (ab30467) to head (5a3be9c). :warning: Report is 10462 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #31728        +/-   ##
================================================
+ Coverage   62.9413%   63.8198%   +0.8785%     
================================================
  Files           774        774                
  Lines        256345     256345                
================================================
+ Hits         161347     163599      +2252     
+ Misses        82023      79719      -2304     
- Partials      12975      13027        +52     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 07 '23 13:08 codecov[bot]