tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

ebs br: add gc immune flag

Open BornChanger opened this issue 11 months ago • 10 comments

What problem does this PR solve?

What is changed and how does it work?

Code changes

Provide an new flag attribute skipGC to VolumeBackup CRD at top level. By setting it manually, customer can make the volumebackup immune to GC triggered by backup scheduler.

  • [x] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [x] Unit test
  • [ ] E2E test
  • [x] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


BornChanger avatar Mar 06 '24 09:03 BornChanger

/cc @WangLe1321 @YuJuncen

BornChanger avatar Mar 06 '24 09:03 BornChanger

/retest

BornChanger avatar Mar 06 '24 09:03 BornChanger

/retest

BornChanger avatar Mar 06 '24 10:03 BornChanger

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.30%. Comparing base (f7c4a71) to head (906fd91).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5567      +/-   ##
==========================================
+ Coverage   61.43%   67.30%   +5.86%     
==========================================
  Files         235      246      +11     
  Lines       30206    34097    +3891     
==========================================
+ Hits        18558    22949    +4391     
+ Misses       9785     9227     -558     
- Partials     1863     1921      +58     
Flag Coverage Δ
e2e 45.88% <0.00%> (?)
unittest 61.42% <22.22%> (-0.02%) :arrow_down:

codecov-commenter avatar Mar 06 '24 12:03 codecov-commenter

/retest

BornChanger avatar Mar 08 '24 09:03 BornChanger

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 09:14:56.744795073 +0000 UTC m=+417723.767041461: :ballot_box_with_check: agreed by WangLe1321.
  • 2024-03-08 09:18:51.393252346 +0000 UTC m=+417958.415498731: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].

ti-chi-bot[bot] avatar Mar 08 '24 09:03 ti-chi-bot[bot]

New changes are detected. LGTM label has been removed.

ti-chi-bot[bot] avatar Mar 08 '24 09:03 ti-chi-bot[bot]

/retest

BornChanger avatar Mar 08 '24 09:03 BornChanger

/run-pull-e2e-kind-across-kubernetes

BornChanger avatar Mar 11 '24 15:03 BornChanger

/run-pull-e2e-kind-br

BornChanger avatar Mar 12 '24 07:03 BornChanger

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 12 '24 08:03 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 12 '24 08:03 ti-chi-bot[bot]

/cherry-pick release-1.5

csuzhangxc avatar Mar 12 '24 08:03 csuzhangxc

@csuzhangxc: new pull request created to branch release-1.5: #5571.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Mar 12 '24 08:03 ti-chi-bot