tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

warmup-image: test WAL files while warming up

Open YuJuncen opened this issue 11 months ago • 3 comments

What problem does this PR solve?

This PR added an ad-hoc precheck for the warmup script.

What is changed and how does it work?

We will run ldb dump_wal on each log files found. It is an ad-hoc solution because the version of ldb is hard-coded. Please don't merge them and only use this to build the warmup image.

Code changes

  • [ ] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [x] Manual test

I run this on a simple storage that contains some corrupted SST files:

CleanShot 2024-03-06 at 17 02 14@2x

  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


YuJuncen avatar Mar 06 '24 09:03 YuJuncen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.66%. Comparing base (01df6ff) to head (9f4621f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
+ Coverage   61.49%   67.66%   +6.17%     
==========================================
  Files         235      246      +11     
  Lines       30335    34228    +3893     
==========================================
+ Hits        18653    23159    +4506     
+ Misses       9813     9164     -649     
- Partials     1869     1905      +36     
Flag Coverage Δ
e2e 47.98% <ø> (?)
unittest 61.47% <ø> (-0.02%) :arrow_down:

codecov-commenter avatar Mar 06 '24 09:03 codecov-commenter

/run-all-tests

HuSharp avatar Mar 27 '24 06:03 HuSharp

The hardcode tikv version seems acceptable now.

BornChanger avatar Mar 28 '24 03:03 BornChanger

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 28 '24 03:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 09:56:14.209321168 +0000 UTC m=+247401.231567557: :ballot_box_with_check: agreed by WangLe1321.
  • 2024-03-26 03:48:19.9774637 +0000 UTC m=+1953326.999710090: :heavy_multiplication_x::repeat: reset by YuJuncen.
  • 2024-03-28 03:24:20.696483573 +0000 UTC m=+2124687.718729946: :ballot_box_with_check: agreed by BornChanger.

ti-chi-bot[bot] avatar Mar 28 '24 03:03 ti-chi-bot[bot]

/merge

BornChanger avatar Mar 28 '24 03:03 BornChanger

@BornChanger: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Mar 28 '24 03:03 ti-chi-bot[bot]

/approve

BornChanger avatar Mar 28 '24 03:03 BornChanger

/cherry-pick release-1.5

BornChanger avatar Mar 28 '24 03:03 BornChanger

@BornChanger: new pull request created to branch release-1.5: #5593.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Mar 28 '24 03:03 ti-chi-bot