tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

ebs br: Handle tagging limit

Open BornChanger opened this issue 1 year ago • 5 comments

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • [x] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [x] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


BornChanger avatar Feb 03 '24 04:02 BornChanger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 03 '24 04:02 ti-chi-bot[bot]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9c48ee5) 61.38% compared to head (5876081) 67.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5538      +/-   ##
==========================================
+ Coverage   61.38%   67.13%   +5.74%     
==========================================
  Files         234      245      +11     
  Lines       29962    33826    +3864     
==========================================
+ Hits        18393    22708    +4315     
+ Misses       9736     9240     -496     
- Partials     1833     1878      +45     
Flag Coverage Δ
e2e 46.26% <0.00%> (?)
unittest 61.39% <0.00%> (+<0.01%) :arrow_up:

codecov-commenter avatar Feb 03 '24 04:02 codecov-commenter

/retest

BornChanger avatar Feb 03 '24 10:02 BornChanger

/run-pull-e2e-kind

BornChanger avatar Feb 03 '24 12:02 BornChanger

/run-pull-e2e-kind-across-kubernetes

BornChanger avatar Feb 03 '24 12:02 BornChanger

It's not necessary now.

BornChanger avatar Mar 12 '24 11:03 BornChanger