tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

backup-manager: try to directly get the backup size from backupmeta before calculate the backup size (#5411)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #5411

What problem does this PR solve?

The current backup-manager cannot parse the backupmetaV2.

Close #5407

What is changed and how does it work?

try to directly get the backup size from backupmeta before calculate the backup size. Notice that if the br supports backupemtaV2, it also supports to record the backup size into the backupmeta.

Code changes

  • [x] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [ ] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


ti-chi-bot avatar Jan 25 '24 07:01 ti-chi-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 25 '24 09:01 ti-chi-bot[bot]

blocked: need to update k8s package

Leavrth avatar Jan 26 '24 02:01 Leavrth