tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

Issue with the indent in deployment-discovery template for resources

Open disser4 opened this issue 1 year ago • 1 comments

This https://github.com/pingcap/tidb-operator/blob/master/charts/tidb-cluster/templates/discovery-deployment.yaml#L50 should not be 12 rather 10.

Suggestion:

{{- with .Values.discovery.resources }} resources: {{ toYaml . | nindent 10 }} {{- end }}

disser4 avatar Apr 25 '23 17:04 disser4

thanks for your report. cloud you open a PR to fix it? But the tidb-cluster Helm chart is deprecated and we recommend using the new TidbCluster CR now.

https://github.com/pingcap/tidb-operator/tree/master/manifests/crd/v1

csuzhangxc avatar Apr 26 '23 02:04 csuzhangxc