tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

Add ServiceSpec for TiKV and Discovery configuration

Open wxiaomou opened this issue 1 year ago • 3 comments

Feature Request

Currently we can specify ServiceSpec in many components but not tikv services, does it make sense to add ServiceSpec for TiKV and discovery configurations?

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

wxiaomou avatar Apr 15 '23 16:04 wxiaomou

TiDB service is acting as the endpoint of a TiDB cluster, so we added Service Spec for it. For TiKV and discovery, any details about the scenario?

csuzhangxc avatar Apr 17 '23 09:04 csuzhangxc

@csuzhangxc we have internal service (istio) that's inspecting all k8s services, we want to add an custom annotation to tikv and tidb discovery services to let our internal service ignore tikv service.

wxiaomou avatar Apr 17 '23 15:04 wxiaomou

As you mentioned, many components have added ServiceSpec, so I think adding it to TiKV for this case is OK.

csuzhangxc avatar Apr 18 '23 02:04 csuzhangxc