tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

Rely on external-resizer to adjust TiKV storage size

Open Tema opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe: tidb-operator talks directly to EBS to resize volume when requested. This requires tidb-operator to have a very broad access, which we try to limit.

Describe the feature you'd like: tidb-operator needs to rely on https://github.com/kubernetes-csi/external-resizer for EBS volume size change instead of accessing EBS directly.

cc: @luohao

Tema avatar Mar 01 '23 00:03 Tema

We may need to add a flag (or just reuse the VolumeModifying feature gate) to let the external-resizer for this.

e.g do not register the modifier for this provisioner.

https://github.com/pingcap/tidb-operator/blob/136086c37bbef479299be2753bc04ba1c5146149/pkg/manager/volumes/pod_vol_modifier.go#L93-L95

csuzhangxc avatar Mar 01 '23 08:03 csuzhangxc