tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

Add a protection mechanism to prevent accidental deletion of TC

Open wxiaoke opened this issue 2 years ago • 3 comments

Feature Request

Is your feature request related to a problem? Please describe:

Due to human operation, TC was deleted by mistake

Describe the feature you'd like:

If there are some tips or a second confirmation, it will be better.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

wxiaoke avatar Dec 12 '22 07:12 wxiaoke

use deletion validation webhook? like https://github.com/maniSbindra/k8s-delete-validation-webhook

csuzhangxc avatar Dec 12 '22 08:12 csuzhangxc

could we integrate the function to tidb operator? I think the reference not fully meet this requirement:When delete CRD,if there are some tips or a second confirmation, it will be better.

wxiaoke avatar Dec 13 '22 06:12 wxiaoke

we need to enhance our webhook, https://docs.pingcap.com/tidb-in-kubernetes/stable/enable-admission-webhook

csuzhangxc avatar Dec 13 '22 09:12 csuzhangxc