tidb-operator
tidb-operator copied to clipboard
pingcap
br: support track tls cluster's log backup progress
What problem does this PR solve?
Ref https://github.com/pingcap/tidb-operator/issues/4645
What is changed and how does it work?
Use PDControl.GetPDEtcdClient to create pd client, it supports tls cluster.
Code changes
- [ ] Has Go code change
- [ ] Has CI related scripts change
Tests
- [ ] Unit test
- [x] E2E test
- [ ] Manual test
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- KanShiori
- csuzhangxc
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #4716 (70065db) into master (c6b7fcc) will increase coverage by
9.80%. The diff coverage is58.53%.
Additional details and impacted files
@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
+ Coverage 61.55% 71.35% +9.80%
==========================================
Files 206 210 +4
Lines 22752 25512 +2760
==========================================
+ Hits 14004 18203 +4199
+ Misses 7446 5987 -1459
- Partials 1302 1322 +20
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 58.17% <63.88%> (?) |
|
| unittest | 61.49% <10.81%> (-0.06%) |
:arrow_down: |
@grovecai: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
LGTM
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
/test pull-e2e-kind-across-kubernetes pull-e2e-kind-tikv-scale-simultaneously
@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.