pingcap
initial support for tiproxy [2/2]
Signed-off-by: xhe [email protected]
What problem does this PR solve?
Depends on #4711
What is changed and how does it work?
- support tiproxy, manualy tested. Two notable differences: first, its dynamic confimap is managed by controller completely, not helm; second, it has two dynamic options that applies on fly using HTTP api by examing difference between
specandstatus. controller.AnnPromis modified to support special metrics pathbaseImagedone right. Without settingbaseImageincharts/tidb-cluster/templates/tidb-cluster.yaml, this option actually does not work. The bug applies to all components though, I just fix tiproxy for now- My local test scripts using
minikubeare added to/hack/localtest, including ssl toolsets. Some lightweight modifications should make it work generally for all components. - updated golangci-lint
Code changes
- [x] Has Go code change
- [x] Has CI related scripts change
Tests
- [ ] Unit test
- [ ] E2E test
- [x] Manual test
./hack/localtest/test.sh all
kubectl port-forward -n testing svc/cluster-tiproxy 6000
mycli -u root -P 6000
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
Initial support for tiproxy
[REVIEW NOTIFICATION]
This pull request has been approved by:
- KanShiori
- csuzhangxc
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #4693 (62437ee) into master (796fe64) will increase coverage by
4.69%. The diff coverage is5.77%.
Additional details and impacted files
@@ Coverage Diff @@
## master #4693 +/- ##
==========================================
+ Coverage 61.19% 65.88% +4.69%
==========================================
Files 212 221 +9
Lines 23887 27346 +3459
==========================================
+ Hits 14617 18017 +3400
+ Misses 7900 7892 -8
- Partials 1370 1437 +67
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 45.23% <4.83%> (?) |
|
| unittest | 59.79% <4.34%> (-1.40%) |
:arrow_down: |
This pull request has been accepted and is ready to merge.
@xhebox: Your PR was out of date, I have automatically updated it for you.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
