pingcap
feat(minReadySeconds): support minReadySeconds in TC annotation
What problem does this PR solve?
What is changed and how does it work?
Code changes
- [x] Has Go code change
- [ ] Has CI related scripts change
Tests
- [x] Unit test
- [ ] E2E test
- [ ] Manual test
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- KanShiori
- csuzhangxc
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #4675 (0865f45) into master (bf12869) will increase coverage by
8.83%. The diff coverage is74.35%.
@@ Coverage Diff @@
## master #4675 +/- ##
==========================================
+ Coverage 63.58% 72.41% +8.83%
==========================================
Files 196 200 +4
Lines 21284 23850 +2566
==========================================
+ Hits 13533 17272 +3739
+ Misses 6532 5346 -1186
- Partials 1219 1232 +13
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 57.74% <46.15%> (?) |
|
| unittest | 63.58% <58.97%> (+<0.01%) |
:arrow_up: |
@KanShiori: /merge in this pull request requires 2 approval(s).
In response to this:
/merge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.
