tidb-operator
tidb-operator copied to clipboard
pingcap
br: add log backup and pitr crd
What problem does this PR solve?
Ref #4645
What is changed and how does it work?
this pr update backup and restore crd.
Code changes
- [x] Has Go code change
- [ ] Has CI related scripts change
Tests
- [ ] Unit test
- [ ] E2E test
- [ ] Manual test
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
add log backup and pitr crd
[REVIEW NOTIFICATION]
This pull request has been approved by:
- KanShiori
- csuzhangxc
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #4648 (c909bf4) into master (9dc513f) will increase coverage by
9.41%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #4648 +/- ##
==========================================
+ Coverage 63.58% 72.99% +9.41%
==========================================
Files 196 200 +4
Lines 21284 23817 +2533
==========================================
+ Hits 13533 17386 +3853
+ Misses 6532 5232 -1300
+ Partials 1219 1199 -20
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 59.82% <ø> (?) |
|
| unittest | 63.57% <ø> (-0.01%) |
:arrow_down: |
@WizardXiao please fix CI https://github.com/pingcap/tidb-operator/runs/7555742109?check_suite_focus=true
@WizardXiao please fix CI https://github.com/pingcap/tidb-operator/runs/7555742109?check_suite_focus=true
ok, i will fix, my github account has problems, and unable to log in, now it has recovered.
@grovecai: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@WizardXiao: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.
In response to this:
/merge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@lichunzhu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.
In response to this:
/merge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
LGTM
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.