tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

[WIP] Upgrade go to 1.18

Open KanShiori opened this issue 2 years ago • 3 comments

What problem does this PR solve?

Close #4474

What is changed and how does it work?

Upgrade go versions to 1.18 in all go.mod.

Upgrade go versions to 1.18 in e2e and git action.

Correct some scripts to support go 1.18.

Code changes

  • [ ] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [ ] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


KanShiori avatar Mar 25 '22 09:03 KanShiori

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Mar 25 '22 09:03 ti-chi-bot

Codecov Report

Merging #4496 (1afa7bb) into master (f208a0f) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4496      +/-   ##
==========================================
- Coverage   62.71%   62.69%   -0.02%     
==========================================
  Files         184      184              
  Lines       19868    19868              
==========================================
- Hits        12460    12457       -3     
- Misses       6274     6276       +2     
- Partials     1134     1135       +1     
Flag Coverage Δ
unittest 62.69% <0.00%> (-0.02%) :arrow_down:

codecov-commenter avatar Mar 25 '22 09:03 codecov-commenter

@KanShiori: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Sep 23 '22 09:09 ti-chi-bot