tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

clean up: remove unused Informer().HasSynced

Open zjj2wry opened this issue 5 years ago • 2 comments

Feature Request

Is your feature request related to a problem? Please describe:

The shared informer factory has called the WaitForCacheSync method, and it is no longer need to call it separately for each controller. We can remove Informer ().HasSynced because it will not be used.

https://github.com/pingcap/tidb-operator/blob/master/pkg/controller/tidbcluster/tidb_cluster_controller.go#L248

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

zjj2wry avatar Jun 01 '20 14:06 zjj2wry

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

github-actions[bot] avatar Aug 08 '20 00:08 github-actions[bot]

/assign

drivebyer avatar Aug 04 '23 05:08 drivebyer