tidb-lightning icon indicating copy to clipboard operation
tidb-lightning copied to clipboard

confused log with "miss host db", "miss host table"

Open csuzhangxc opened this issue 5 years ago • 3 comments

what does "host" mean here? try to update the log to make it clearer?

csuzhangxc avatar Oct 21 '20 10:10 csuzhangxc

(the terminology traced back to the very beginning, so probably no one here knows why "host" was used 😅)

https://github.com/pingcap/tidb-lightning/blob/75af9bb8b1f3d8854e18f9b8f0749d82695e0d9f/ingest/mydump/loader.go#L193-L196

anyway the "host table" error is thrown when we try to import db.tbl.1234.sql, but the schema of the table db.tbl does not exist.

so perhaps change the wordings to:?

invalid data file, cannot find db '%s'

invalid data file, cannot find table '%s'

kennytm avatar Oct 21 '20 13:10 kennytm

invalid data file, cannot find db '%s'

invalid data file, cannot find table '%s'

but cannot find the schema file for db '%s'?

csuzhangxc avatar Oct 21 '20 13:10 csuzhangxc

there's no need for schema file in --no-schema mode, but the table still needs to exist on TiDB

kennytm avatar Oct 21 '20 14:10 kennytm