tidb-dev-guide icon indicating copy to clipboard operation
tidb-dev-guide copied to clipboard

It might be better to open 'Go's download page' link in a new tab.

Open sunxiaoguang opened this issue 4 years ago • 5 comments

image

It might be better to open 'Go's download page' link in a new tab as we really just want to download go at background and keep reading the book.

sunxiaoguang avatar Aug 16 '21 16:08 sunxiaoguang

Make sense. I'll create a pull request. May we just replace the default []() syntax with <a target="_blank">...</a>

tisonkun avatar Aug 16 '21 16:08 tisonkun

@sunxiaoguang @siddontang we can use target="_blank" to implement it here.

But I'm thinking of whether or not we apply/evaluate this rule to all links. Since in Safari or Chrome we can easily open a link in new tab by Cmd + Shift + Click [1], I tend to leave the function to the browser than pollute raw html here.

[1] https://support.google.com/chromebook/thread/685410/how-do-i-set-the-default-on-open-in-a-new-tab-to-automatically-switch-to-that-tab?hl=en

tisonkun avatar Aug 16 '21 16:08 tisonkun

I think only a few of them worth opening in new tab. Most can remain the same.

sunxiaoguang avatar Aug 16 '21 16:08 sunxiaoguang

I think only a few of them worth opening in new tab. Most can remain the same.

so what's your opinion on links worth opening in new tab by default? I'm confused since in this page all links looks reasonable to be opened in a new tab.

tisonkun avatar Aug 16 '21 16:08 tisonkun

If the browser can do you a favor, I'd prefer leave the choice to the user. How to open a link is always under control of the user.

tisonkun avatar Aug 16 '21 16:08 tisonkun