tidb-dev-guide
tidb-dev-guide copied to clipboard
pingcap
update optimistic-transaction.md
What issue does this PR solve?
- close #114
What is changed:
Added dev guide article for optimistic transaction
How the temp mutations of optimistic transactions are buffered in TiDB may be discussed.
@you06 @cfzjywxk @sticnarf @tisonkun ping, what's your opinions about the current patch?
There are still some format issues:
- The bold marks are not work in code blocks, which should be removed.
- The main body's function names are in quotation marks, it would be better to put them in backquotes, so they look like
func fn().
For the contents of this patch, there are many details of how TiDB implement optimistic transaction like batch processing which looks good, however, some details are missing like error handling(retry or resolve locks).
I think we can accept this document after the format issues are fixed. If someone thinks there are too many code references or any details that are worth mentioned, a further patch will improve this document.
There are still some format issues:
- The bold marks are not work in code blocks, which should be removed.
- The main body's function names are in quotation marks, it would be better to put them in backquotes, so they look like
func fn().For the contents of this patch, there are many details of how TiDB implement optimistic transaction like batch processing which looks good, however, some details are missing like error handling(retry or resolve locks).
I think we can accept this document after the format issues are fixed. If someone thinks there are too many code references or any details that are worth mentioned, a further patch will improve this document.
I have fixed the format issues, thanks. Why so mush code in this paper? I think the new developers want to position the important functions quickly and read the code in detail for a transaction process flow.