tidb-dashboard icon indicating copy to clipboard operation
tidb-dashboard copied to clipboard

Support more browsers

Open breezewish opened this issue 5 years ago • 6 comments

Feature Request

Is your feature request related to a problem? Please describe:

Currently we only support very recent browsers.

Describe the feature you'd like:

The support may be extended by shipping polyfills for legacy browsers.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Reference: https://www.smashingmagazine.com/2018/10/smart-bundling-legacy-code-browsers/

Note that it would be better to decide the polyfill at client side. See https://github.com/browserslist/browserslist-useragent-regexp

breezewish avatar Jun 15 '20 12:06 breezewish

Although we can do this, the main used library - ant design 4.0 only support the latest modern browsers: https://ant.design/docs/react/introduce-cn#%E5%85%BC%E5%AE%B9%E7%8E%AF%E5%A2%83

In my opinion, the dashboard is a product toB, not toC. Unlike toC, it rarely happens that the user decides to not use this product (and TiDB) just because it can't run in his browser. I think it is fine to prompt users to upgrade their browser if the browser is outdated. And support legacy browsers will limit us to use some new web technologies. Of course, this is just my personal view.

baurine avatar Jun 16 '20 02:06 baurine

@baurine We have already met several important clients using an old browser like a Chrome published 3 years ago. If we can support this case then it would be great.

breezewish avatar Jun 16 '20 02:06 breezewish

Maybe we should declare the supported browsers list in our documentation as well likes grafana: https://grafana.com/docs/grafana/latest/installation/requirements/#supported-web-browsers

baurine avatar Jun 16 '20 02:06 baurine

@baurine See #640

breezewish avatar Jun 16 '20 03:06 breezewish

Got it and make sense. I talked with DBA, the clients may use a very old Chrome or Firefox browser (they won't upgrade it after installing), but they don't use IE anymore.

baurine avatar Jun 16 '20 04:06 baurine

@baurine Yeah, so a fixed version list is very necessary.

breezewish avatar Jun 16 '20 11:06 breezewish