tidb-dashboard icon indicating copy to clipboard operation
tidb-dashboard copied to clipboard

Add backend supports for tso and scheduling

Open rleungx opened this issue 1 year ago β€’ 6 comments

The component name might be changed later. Ref #1651

rleungx avatar Feb 21 '24 06:02 rleungx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 21 '24 06:02 CLAassistant

Deploy Preview for tidb-dashboard ready!

Name Link
Latest commit a86edef44faf210e256eee657f46f41f4672da41
Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65f2890ff9e3b40008e95afc
Deploy Preview https://deploy-preview-1648--tidb-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 21 '24 06:02 netlify[bot]

Codecov Report

Attention: Patch coverage is 3.42466% with 282 lines in your changes are missing coverage. Please review.

Project coverage is 23.67%. Comparing base (abee03e) to head (a86edef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   24.08%   23.67%   -0.42%     
==========================================
  Files         173      177       +4     
  Lines       15754    16040     +286     
==========================================
+ Hits         3795     3798       +3     
- Misses      11675    11958     +283     
  Partials      284      284              
Flag Coverage Ξ”
backend_integration 8.98% <3.67%> (-0.19%) :arrow_down:
backend_ut 26.17% <0.00%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update abee03e...a86edef. Read the comment docs.

codecov[bot] avatar Feb 21 '24 06:02 codecov[bot]

@mornyx PTAL

rleungx avatar Feb 28 '24 06:02 rleungx

I will help review next week.

@rleungx , can you elaborate the PR when you're free, for example, how to build the dev env so I can test the PR, attach some screenshots. thanks~

baurine avatar Mar 08 '24 00:03 baurine

test:

tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1

baurine avatar Mar 14 '24 02:03 baurine

screenshot:

image

image

image

image

baurine avatar Mar 14 '24 03:03 baurine

test compatibility, connect with tidb 7.5.0 cluster, reports following error in the cluster info page:

img_v3_028v_c0ee8a24-2ba7-435b-8271-f41b0e31a16g

baurine avatar Mar 14 '24 04:03 baurine

fix the following errors in commit: https://github.com/pingcap/tidb-dashboard/commit/c0d16250c0cded8bb7677a73f412f7ea3fcbb394 , after cherry-pick this commit, this PR is able to be approved.

baurine avatar Mar 14 '24 04:03 baurine

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 14 '24 05:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 05:41:07.228163195 +0000 UTC m=+923294.250409579: :ballot_box_with_check: agreed by baurine.

ti-chi-bot[bot] avatar Mar 14 '24 05:03 ti-chi-bot[bot]