tidb-dashboard
tidb-dashboard copied to clipboard
forwarder: close goroutine leak when block in accept
related https://github.com/tikv/pd/pull/7782
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign deardrops for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Deploy Preview for tidb-dashboard canceled.
Name | Link |
---|---|
Latest commit | cce4e52a51f81d6f5a3f01c9c8885ddf56fcdf9f |
Latest deploy log | https://app.netlify.com/sites/tidb-dashboard/deploys/65c1dfe9addb9d0008563ebf |
Codecov Report
Attention: Patch coverage is 91.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 24.17%. Comparing base (
5e932ec
) to head (cce4e52
). Report is 16 commits behind head on master.
:exclamation: Current head cce4e52 differs from pull request most recent head f3b363d
Please upload reports for the commit f3b363d to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 23.68% 24.17% +0.49%
==========================================
Files 177 173 -4
Lines 16055 15725 -330
==========================================
- Hits 3802 3801 -1
+ Misses 11968 11638 -330
- Partials 285 286 +1
Flag | Coverage Ξ | |
---|---|---|
backend_integration | 9.29% <91.66%> (+0.30%) |
:arrow_up: |
backend_ut | 26.28% <54.16%> (+0.09%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update c30f979...f3b363d. Read the comment docs.
@shhdgit @baurine PTAL, thx!
@mornyx please help review , thanks~
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign deardrops for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment