tidb-dashboard icon indicating copy to clipboard operation
tidb-dashboard copied to clipboard

*:upgrade mockery to make sure this project builds under go 1.18

Open longfangsong opened this issue 3 years ago • 3 comments

close #1366 (replace it)

Current version of mockery used by this project does not support go 1.18. According to the suggestion of the maitainer of this project, we should upgrade it and drop the support of old Golang compiler.

This PR do the upgrade work and push the minium supported Golang version to 1.18

longfangsong avatar Aug 02 '22 00:08 longfangsong

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 02 '22 00:08 ti-chi-bot

Codecov Report

Merging #1382 (f3934d6) into master (65d9c82) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
- Coverage   29.44%   29.43%   -0.01%     
==========================================
  Files         128      128              
  Lines       10519    10525       +6     
  Branches       99       99              
==========================================
+ Hits         3097     3098       +1     
- Misses       7242     7247       +5     
  Partials      180      180              
Flag Coverage Δ
be_unit_test 27.57% <0.00%> (-0.01%) :arrow_down:
e2e_test 63.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65d9c82...f3934d6. Read the comment docs.

codecov-commenter avatar Aug 02 '22 00:08 codecov-commenter

I guess the Golang compiler version specified in the CI yaml also need to be updated.

breezewish avatar Aug 02 '22 02:08 breezewish

@coderplay: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Thanks for adding this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Nov 04 '22 18:11 ti-chi-bot

@longfangsong: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Nov 07 '22 09:11 ti-chi-bot