tidb-dashboard icon indicating copy to clipboard operation
tidb-dashboard copied to clipboard

fix ui doesn't work when running backend without 'feature-version' option

Open baurine opened this issue 3 years ago • 3 comments

close #1177

Try to dismiss the FEATURE_VERSION conception, use PDVersion directly to reduce the understanding confusion.

baurine avatar Feb 10 '22 10:02 baurine

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Feb 10 '22 10:02 ti-chi-bot

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 29.17%. Comparing base (330f96e) to head (948703b). Report is 255 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   29.13%   29.17%   +0.03%     
==========================================
  Files         286      286              
  Lines       16941    16933       -8     
  Branches      646      646              
==========================================
+ Hits         4936     4940       +4     
+ Misses      11774    11762      -12     
  Partials      231      231              
Flag Coverage Δ
be_integration_test_latest 9.31% <50.00%> (+0.02%) :arrow_up:
be_integration_test_v4.0.1 9.30% <50.00%> (+0.02%) :arrow_up:
be_unit_test 24.07% <0.00%> (ø)
e2e_test 63.49% <ø> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 330f96e...948703b. Read the comment docs.

codecov-commenter avatar Feb 11 '22 09:02 codecov-commenter

@baurine: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Feb 25 '22 17:02 ti-chi-bot