Chrome 55 doesn't show compatibility warning banner

[baurine]

Bug Report

Please answer these questions before submitting your issue. Thanks!

What did you do?

Run TiDB Dashboard in Chrome 55, overview and statement pages can't display after running cluster diagnostic feature.

What did you expect to see?

It should display a compatibility warning banner to ask the user to upgrade the browser.

What did you see instead?

The banner doesn't display.

What version of TiDB Dashboard are you using (./tidb-dashboard --version)?

5.0.4

[breezewish]

Currently this becomes worse due to our new version requirement by introducing import ... from syntax.

[baurine]

Currently this becomes worse due to our new version requirement by introducing import ... from syntax.

I am thinking about how to refine the compatibility check, it seems esbuild doesn't care about the browserslist configuration so the old check strategy doesn't work any more.

[breezewish]

Currently this becomes worse due to our new version requirement by introducing import ... from syntax.

I am thinking about how to refine the compatibility check, it seems esbuild doesn't care about the browserslist configuration so the old check strategy doesn't work any more.

Good to know. I have similar thoughts.

From my understanding, we have multiple things to consider:

1. JavaScript compatibility - This can be controlled by specifying a target ECMA version to esbuild.
2. CSS prefix compatibility - This can be controlled by PostCSS + browserlist.

The minimal version we support should be max(js_version, css_version). And we want to make this minimal version the lower the better.

After discovering the minimal version, maybe we can use some explicit version checks I guess. Not for sure.