kvproto icon indicating copy to clipboard operation
kvproto copied to clipboard

[DNM] rename resolved_ts to watermark

Open zhangjinpeng87 opened this issue 10 months ago • 2 comments

Part of https://github.com/tikv/tikv/issues/16708

  • Rename resolved_ts to name watermark if it is a field. Rename proto filed name without change its id is compatible.
  • Keep PD API rpc ReportMinResolvedTS(ReportMinResolvedTsRequest) returns (ReportMinResolvedTsResponse) {} for compatibility reason, at the same time add rpc ReportMinWatermark(ReportMinWatermarkRequest) returns (ReportMinWatermarkResponse) {} which will replace the former one in the future.

zhangjinpeng87 avatar Mar 29 '24 20:03 zhangjinpeng87

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuhuizuo Once this PR has been reviewed and has the lgtm label, please assign bornchanger, cfzjywxk, lance6716, overvenus, rleungx, tonyxuqqi for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 15 '24 00:04 ti-chi-bot[bot]

@wuhuizuo: Please do not delete or edit you lgtm type comment!

In response to this:

/approve /lgtm

just for test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 15 '24 00:04 ti-chi-bot[bot]