gdocwiki icon indicating copy to clipboard operation
gdocwiki copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

Migrate deprecated google auth to GSI

Open gsipos opened this issue 2 years ago • 6 comments

The Google Sing-In Javascript platform library for Web has been deprecated, and will be unavailable after March 31, 2023. This PR aims to resolve that by migrating to the newer GSI library.

https://developers.google.com/identity/oauth2/web/guides/migration-to-gis#library_quick_reference

solves #161

gsipos avatar Mar 09 '23 12:03 gsipos

@breezewish fyi

gsipos avatar Mar 09 '23 12:03 gsipos

I am eagerly waiting for this issue to get resolved.

How can we get someone to review this, so that it can be merged? Maybe add them to Reviewers?

adaviding avatar Mar 28 '23 22:03 adaviding

How can we get someone to review this, so that it can be merged? Maybe add them to Reviewers?

I don't have access to set reviewers, I believe only repo contributors can do that.

gsipos avatar Mar 29 '23 10:03 gsipos

@gregwebs This issue is actively blocking anybody using this wiki. The author does not have authority to add a reviewer. Can you please review this so we can get it merged?

adaviding avatar Mar 30 '23 18:03 adaviding

@gsipos LGTM. I don't have write access to this repo. Are you maintaining a fork?

gregwebs avatar Aug 14 '23 17:08 gregwebs

I am not maintaining a fork. @breezewish is the only other developer that I can see from the commit history.

adaviding avatar Aug 14 '23 17:08 adaviding