errors icon indicating copy to clipboard operation
errors copied to clipboard

replace go.uber.org/atomic with sync/atomic

Open serprex opened this issue 11 months ago • 1 comments

raises go version to 1.18

this is a breaking change since consumers will update with errors.RedactLogEnabled.Store(&errors.RedactLogEnable). ideally this wouldn't be exposed & instead there'd be a function errors.SetRedactLogEnabled(...) & even better the enum would be an integer which could then use atomic.Int32 in behind

serprex avatar Jan 15 '25 18:01 serprex

(note that modern go.uber.org/atomic uses these atomic types, their String is specialization built on top of Value which is takes interface{} for Load/Store)

https://github.com/uber-go/atomic/blob/v1.11.0/string.go#L26 https://github.com/uber-go/atomic/blob/v1.11.0/value.go#L27

serprex avatar Jan 15 '25 18:01 serprex