docs icon indicating copy to clipboard operation
docs copied to clipboard

develop: add non-transactional delete

Open Icemap opened this issue 2 years ago • 6 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [x] v6.2 (TiDB 6.2 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs-cn/pull/10814
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

Icemap avatar Aug 08 '22 10:08 Icemap

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 08 '22 10:08 ti-chi-bot

/cc @Oreoxmt

Icemap avatar Aug 08 '22 10:08 Icemap

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time @Icemap @ekexium We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

cfzjywxk avatar Aug 22 '22 03:08 cfzjywxk

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time @Icemap @ekexium We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

IMO we don't have to explain as much details as crdb, though they can be found in the original doc. @Icemap Could you help put a summary here so that users know its advantage and how-tos at their first glance?

ekexium avatar Aug 29 '22 08:08 ekexium

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time @Icemap @ekexium We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

This is the Developer Guide, which corresponds to this section of CockroachDB: https://www.cockroachlabs.com/docs/stable/delete-data.html . By contrast, I think we've added a lot of examples. @ekexium @cfzjywxk

Icemap avatar Sep 05 '22 07:09 Icemap

/status LGT1

Oreoxmt avatar Sep 05 '22 08:09 Oreoxmt

@Icemap: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Oct 29 '22 09:10 ti-chi-bot

@Oreoxmt Please consider merging this, the Chinese version is already merged (https://github.com/pingcap/docs-cn/pull/10814)

SunRunAway avatar Dec 07 '22 06:12 SunRunAway

/merge

Oreoxmt avatar Dec 07 '22 07:12 Oreoxmt

This pull request has been accepted and is ready to merge.

Commit hash: 59da794adf16f852180289c32946aa183e94c22f

ti-chi-bot avatar Dec 07 '22 07:12 ti-chi-bot

In response to a cherrypick label: new pull request created: #11548.

ti-chi-bot avatar Dec 07 '22 07:12 ti-chi-bot

In response to a cherrypick label: new pull request created: #11549.

ti-chi-bot avatar Dec 07 '22 07:12 ti-chi-bot

In response to a cherrypick label: new pull request created: #11550.

ti-chi-bot avatar Dec 07 '22 07:12 ti-chi-bot

In response to a cherrypick label: new pull request created: #11551.

ti-chi-bot avatar Dec 07 '22 07:12 ti-chi-bot