docs
docs copied to clipboard
migration-tools: avoid wide table
What is changed, added or deleted? (Required)
The table on https://docs.pingcap.com/tidb/stable/migration-tools doesn't really fit it the current page layout and cause the table to scroll which makes it hard to read.
This changes the layout to remove one column of the table.
Also fix some Lighting
→ Lightning
issues.
Which TiDB version(s) do your changes apply to? (Required)
- [x] master (the latest development version)
- [x] v6.2 (TiDB 6.2 versions)
- [x] v6.1 (TiDB 6.1 versions)
- [ ] v5.4 (TiDB 5.4 versions)
- [ ] v5.3 (TiDB 5.3 versions)
- [ ] v5.2 (TiDB 5.2 versions)
- [ ] v5.1 (TiDB 5.1 versions)
- [ ] v5.0 (TiDB 5.0 versions)
What is the related PR or file link(s)?
- This PR is translated from:
- Other reference link(s):
Do your changes match any of the following descriptions?
- [ ] Delete files
- [ ] Change aliases
- [ ] Need modification after applied to another branch
- [ ] Might cause conflicts after applied to another branch
[REVIEW NOTIFICATION]
This pull request has been approved by:
- ran-huang
- shichun-0415
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@dveeden: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cc @qiancai @TomShawn
/rebase
@dveeden Sorry for the slow response! I made a preview deployment of your changes. They look much better than the current tables. However, if I visit this page on a device with a small screen, it doesn't look so nice as on a large monitor.
So I'm thinking about transposing the table -- switching the rows and columns. Please look at this preview deployment in which I transposed the first 4 tables, and let me know what you think. Thanks! 😃
@dveeden Sorry for the slow response! I made a preview deployment of your changes. They look much better than the current tables. However, if I visit this page on a device with a small screen, it doesn't look so nice as on a large monitor.
So I'm thinking about transposing the table -- switching the rows and columns. Please look at this preview deployment in which I transposed the first 4 tables, and let me know what you think. Thanks! smiley
Yes that's a smart solution. The formatting needs a very small fix as the first column should be in bold instead of the first row after transposing the table.
/merge
This pull request has been accepted and is ready to merge.
In response to a cherrypick label: new pull request created: #11136.
In response to a cherrypick label: new pull request created: #11137.
In response to a cherrypick label: new pull request created: #11138.