docs icon indicating copy to clipboard operation
docs copied to clipboard

Update keywords and add check workflow

Open dveeden opened this issue 3 weeks ago • 3 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update keyword checking script and add it to a workflow.

Updates to keywords from:

  • https://github.com/pingcap/tidb/pull/61159
  • https://github.com/pingcap/tidb/pull/64772
  • https://github.com/pingcap/tidb/pull/59820
  • https://github.com/pingcap/tidb/pull/61299

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v9.0 (TiDB 9.0 versions)
  • [ ] v8.5 (TiDB 8.5 versions)
  • [ ] v8.1 (TiDB 8.1 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

dveeden avatar Dec 05 '25 12:12 dveeden

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Dec 05 '25 12:12 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 05 '25 12:12 ti-chi-bot[bot]

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the existing keyword checking mechanism by replacing a shell script with a more robust and flexible Python script. The primary purpose is to improve the maintainability and adaptability of the keyword validation process, especially by allowing the parser.y definition to be fetched remotely, which can be beneficial for CI/CD pipelines or environments where local file paths might vary.

Highlights

  • Script Renamed and Rewritten: The keyword checking script has been renamed from check-keywords.sh to check-keywords.py and completely rewritten in Python.
  • Flexible Parser Source: The new Python script introduces the ability to specify the parser.y file either from a local path or by downloading it directly from a URL, enhancing flexibility for different environments.
  • Command-Line Arguments: Command-line arguments (--parser_file, --parser_url, --download_from_url) have been added to control the source and method of obtaining the parser.y file.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/keywords.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 05 '25 12:12 gemini-code-assist[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 07:09:43.632823557 +0000 UTC m=+1629728.446601129: :ballot_box_with_check: agreed by breezewish.

ti-chi-bot[bot] avatar Dec 17 '25 07:12 ti-chi-bot[bot]